Some refactoring in the base class #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsalehipour
requested changes
Oct 16, 2023
…ter errors, as well as fixed a bug in the distributed processing. Removed portpicker as a dependency as it can't be used for multi-process computations.
hsalehipour
requested changes
Oct 16, 2023
examples/CFD/windtunnel3d.py
Outdated
| @@ -109,7 +110,7 @@ def output_data(self, **kwargs): | |||
|
|
|||
| if __name__ == '__main__': | |||
| precision = 'f32/f32' | |||
| lattice = LatticeD3Q27(precision) | |||
There was a problem hiding this comment.
This should be D3Q27 not D3Q19
src/base.py
Outdated
| if self.nz == 0 and not isinstance(value, LatticeD2Q9): | ||
| raise ValueError("For 2D simulations, lattice type must be LatticeD2Q9.") | ||
| if self.nz != 0 and isinstance(self, src.models.KBCSim) and not isinstance(value, LatticeD3Q27): | ||
| raise ValueError("For 3D KBC simulations, lattice type must be LatticeD3Q19,") |
There was a problem hiding this comment.
The message is incorrect. The lattice myst be D3Q27. Also I would not include this check that relyes on model specific information (KBCSim here) inside the base class. You should raise an error inside models.py for KBCSim
src/base.py
Outdated
| def lattice(self, value): | ||
| if value is None: | ||
| raise ValueError("Lattice type must be provided.") | ||
| if self.nz == 0 and not isinstance(value, LatticeD2Q9): |
There was a problem hiding this comment.
This does not "assume" any default lattice for 2D scenarios. We can still assume D2Q9 for 2D flows and D3Q27 for 3D flows for ALL cases as the default setting when no lattice input is defined by the user.
|
All comments are addressed. |
hsalehipour
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.